Repository navigation
Fix bugs - #1
Merged
Merged
Fix bugs#1
Conversation
chore: test bounds checking
chishxd
approved these changes
Sep 24, 2026
chishxd
left a comment
chishxd
left a comment
Owner
There was a problem hiding this comment.
Beautiful, thanks for the PR! Some dumb mistakes from my side, I could have done better there so you would never have to open PR here... Great job 💖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug #1:
No bounds checking in key length.
Bug #2
No bound checking for value length and it panics on anything over 1024 bytes.
Bug #3
A crash or power loss during a write leaves an incomplete (torn) record at the end of the file. This caused
get()to crash and was fixed by validating each record's value bytes during index rebuild and truncating back to the last valid record so subsequent writes work.